Fix notifyEvent#27
Closed
pm-michael wants to merge 1 commit intotempusdominus:masterfrom
pm-michael:patch-1
Closed
Fix notifyEvent#27pm-michael wants to merge 1 commit intotempusdominus:masterfrom pm-michael:patch-1
pm-michael wants to merge 1 commit intotempusdominus:masterfrom
pm-michael:patch-1
Conversation
Contributor
|
think this is fixed with #31. I'm going to be moving everything back to eonasdan/tempus-dominus so if this isn't fixed for you in the v6 (coming soon), please open another ticket |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the update event was not triggering, and it seems to be due to these lines:
If the
dateandoldDateproperties are not set (eg. for update), then this will always return early and not trigger the event.